Precomputing tier odds #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asselstine
reviewed
Jun 28, 2023
|
|
||
| } | ||
| SD59x18 internal immutable TIER_ODDS_0_3; |
There was a problem hiding this comment.
Tier odds will always be less than 0 <= 1, so you can use the 64-bit SD1x18.
This should save gas
src/PrizePool.sol
Outdated
| revert InvalidTier(_tier, _numberOfTiers); | ||
| } | ||
|
|
||
| tierOdds = TieredLiquidityDistributor._tierOdds(_tier, numberOfTiers); |
There was a problem hiding this comment.
Why is this written so strangely with the Superclass qualifier?
src/PrizePool.sol
Outdated
| startTimestamp = uint64( | ||
| endTimestamp - | ||
| TierCalculationLib.estimatePrizeFrequencyInDraws( | ||
| TieredLiquidityDistributor._tierOdds(_tier, numberOfTiers) |
There was a problem hiding this comment.
funny syntax? isn't it just an internal fxn?
dylandesrosier
force-pushed
the
precomputing-tier-odds
branch
from
bd3499a
to
8892ac2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.